Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Error Prone. #6230

Closed
wants to merge 1 commit into from
Closed

Update Error Prone. #6230

wants to merge 1 commit into from

Commits on Nov 3, 2022

  1. Update Error Prone.

    This has some effects on us as we develop Guava, but it doesn't affect end users.
    
    Specifically:
    
    - When we build Guava with JDK8, we now have to disable Error Prone. (Again, users can still use Guava with JDK8, including with Error Prone. The effect is limited to people who are developing Guava.)
    - We can now successfully build Guava with Error Prone under more recent JDKs. That is, this change should fix the error reported in #6217 (comment). (I'm not sure if the Error Prone update was necessary for that or if only the other `pom.xml` changes were. Still, it seems inevitable that we'll be forced to upgrade Error Prone eventually, and it's rarely a bad idea to update a plugin.)
    
    This change is progress toward building and testing under Java 17 (#5801)...
    
    ...which we apparently regressed at when we enabled Error Prone (#2484).
    
    Oddly, it seems that part of our existing Error Prone setup is _required_ to continue building Guava under JDK8. (Such builds are potentially useful for #3990 or for anyone building Guava manually with an old JDK.) That's the case even though we're now disabling Error Prone for those builds.
    
    Again, all these changes affect only people who are developing Guava, not end users.
    
    RELNOTES=n/a
    PiperOrigin-RevId: 484299394
    cpovirk authored and Google Java Core Libraries committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    4e08591 View commit details
    Browse the repository at this point in the history