review comments

google · Mar 11, 2024 · 2e48525 · 2e48525
1 parent 1995ae7
commit 2e48525
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/include/Dialect/TensorExt/IR/TensorExtCanonicalization.td b/include/Dialect/TensorExt/IR/TensorExtCanonicalization.td
@@ -11,26 +11,13 @@ defvar DefOverflow = ConstantEnumCase<Arith_IntegerOverflowAttr, "none">;
 
 def MakeSingleResultVariadic: NativeCodeCall<"{ $0 }">;
 
-def IndexType : NativeCodeCall<"$_builder.getIndexType()">;
-
-def MakeMatchingTypedZero : NativeCodeCall<
-      "$_builder.getIntegerAttr("
-        "$_builder.getIntegerType("
-          "$0.getType().getIntOrFloatBitWidth()"
-        "), 0)">;
-
 def CreateIndexCastOp : NativeCodeCall<
       "$_builder.create<arith::IndexCastOp>($0.getLoc(), $1.getType(), $0)">;
 
 def IsZero :
     Constraint<
       CPred<"llvm::cast<mlir::IntegerAttr>($0).getValue().isZero()">>;
 
-def AreOpposites :
-    Constraint<
-      CPred<"llvm::cast<mlir::IntegerAttr>($0).getValue() "
-            "== llvm::cast<mlir::IntegerAttr>($1).getValue()">>;
-
 def OutOfBoundsOfTensorDim :
   Constraint<
     CPred<

diff --git a/lib/Dialect/TensorExt/Transforms/InsertRotate.cpp b/lib/Dialect/TensorExt/Transforms/InsertRotate.cpp
@@ -15,7 +15,7 @@ namespace tensor_ext {
 #include "include/Dialect/TensorExt/Transforms/Passes.h.inc"
 
 namespace alignment {
-// In an inner namespace to avoid conflicts with canonicaliation patterns
+// In an inner namespace to avoid conflicts with canonicalization patterns
 #include "include/Dialect/TensorExt/Transforms/InsertRotate.cpp.inc"
 }  // namespace alignment