Adding cggi-tfhe-rs-bool pass + Add tests + And_packed #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
WoutLegiest
commented
Mar 5, 2024
WoutLegiest
commented
- Adding packed version of the And operation to the tfhe-rs-bool emitter
- Adding two tests where an add operation is implemented using boolean operations, for cggi to tfhe-rs-bool and tfhe-rs-bool code emitting
- Organising of the tfhe-rs e2e tests;
WoutLegiest
force-pushed
the
tfhe-rs-fpga
branch
3 times, most recently
from
5bbd974
to
da8ba6d
Compare
j2kun
requested changes
Mar 6, 2024
WoutLegiest
force-pushed
the
tfhe-rs-fpga
branch
from
da8ba6d
to
c8c0d50
Compare
j2kun
approved these changes
Mar 7, 2024
j2kun
added
the
pull_ready
|
You will need to squash your commits, but otherwise LGTM! |
WoutLegiest
force-pushed
the
tfhe-rs-fpga
branch
from
df3856e
to
c865470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.