Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DRR helpers into a Utils.td file #518

Merged
merged 1 commit into from Mar 12, 2024
Merged

Refactor DRR helpers into a Utils.td file #518

merged 1 commit into from Mar 12, 2024

Conversation

j2kun
Copy link
Collaborator

@j2kun j2kun commented Mar 11, 2024

Fixes #515

@j2kun j2kun requested a review from asraa March 11, 2024 19:22
asraa
asraa approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(2nd commit) LGTM!

@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Mar 11, 2024
@copybara-service copybara-service bot merged commit a5fcef5 into google:main Mar 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asraa asraa asraa approved these changes

Assignees
No one assigned
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor DRR helper functions into a centralized location
2 participants
@j2kun @asraa