Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add secret-to-bgv conversion for ciphertext arith ops #528

Merged
merged 0 commits into from Mar 19, 2024

Conversation

copybara-service[bot]
Copy link
Contributor

@copybara-service copybara-service bot commented Mar 13, 2024

feat: Add secret-to-bgv conversion for ciphertext arith ops

Adds parameter setting options. All secret inputs are required to be a uniform tensor shape that matches the ring dimension in the parameters specified.

@asraa asraa marked this pull request as draft March 13, 2024 19:27
@copybara-service copybara-service bot force-pushed the test_615502361 branch 3 times, most recently from 7f15c71 to 28e4ac1 Compare March 14, 2024 17:39
@copybara-service copybara-service bot changed the title Add secret-to-bgv conversion feat: Add secret-to-bgv conversion Mar 14, 2024
@copybara-service copybara-service bot changed the title feat: Add secret-to-bgv conversion feat: Add secret-to-bgv conversion for ciphertext arith ops Mar 14, 2024
@asraa asraa marked this pull request as ready for review March 15, 2024 15:27
@asraa asraa requested a review from j2kun March 15, 2024 15:27
Copy link
Collaborator

@j2kun j2kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits!

include/Dialect/BGV/IR/BGVOps.td Outdated Show resolved Hide resolved
tests/secret_to_bgv/invalid.mlir Outdated Show resolved Hide resolved
lib/Conversion/SecretToBGV/SecretToBGV.cpp Outdated Show resolved Hide resolved
lib/Conversion/SecretToBGV/SecretToBGV.cpp Outdated Show resolved Hide resolved
lib/Conversion/SecretToBGV/SecretToBGV.cpp Outdated Show resolved Hide resolved
lib/Conversion/SecretToBGV/SecretToBGV.cpp Outdated Show resolved Hide resolved
lib/Conversion/SecretToBGV/SecretToBGV.cpp Outdated Show resolved Hide resolved
@copybara-service copybara-service bot force-pushed the test_615502361 branch 2 times, most recently from b9b5b58 to 82191ee Compare March 19, 2024 17:37
@copybara-service copybara-service bot closed this Mar 19, 2024
@copybara-service copybara-service bot merged commit cf91085 into main Mar 19, 2024
@copybara-service copybara-service bot deleted the test_615502361 branch March 19, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants