Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dialect template generation #550

Merged
merged 1 commit into from Mar 24, 2024

Conversation

j2kun
Copy link
Collaborator

@j2kun j2kun commented Mar 23, 2024

Minor changes to the dialect template generation tool found during #549

  • make include guards consistent with other templates (remove leading HEIR_, capitalize class name)
  • Add types header to type build rule
  • fix types header include in type cc file

@j2kun j2kun requested a review from asraa March 23, 2024 20:50
@asraa asraa added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Mar 24, 2024
@copybara-service copybara-service bot merged commit c83a1b0 into google:main Mar 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants