Update tfhe-rs-bool-emitter: cggi to tfhe-rs-bool fpga ready code #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
WoutLegiest
commented
Mar 27, 2024
WoutLegiest
commented
- Update the tfhe-rs-bool emitter to now emit working FPGA tfhe-rs-bool code
- Remove the and_packed operations
- Update the tests to work with the new emitted code and the removal of the packed operations
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
WoutLegiest
force-pushed
the
try3
branch
2 times, most recently
from
ad9b7b1
to
da9d95e
Compare
j2kun
approved these changes
Mar 28, 2024
asraa
reviewed
Mar 28, 2024
| @@ -165,29 +168,70 @@ void TfheRustBoolEmitter::emitAssignPrefix(Value result) { | |||
| os << "let " << variableNames->getNameForValue(result) << " = "; | |||
| } | |||
|
|
|||
| void TfheRustBoolEmitter::emitReferenceConversion(Value value) { | |||
There was a problem hiding this comment.
nit: could you also add a quick assertion here that the value element type is a EncryptedUint (or maybe add this to the doc-string in the header file that it's expected to run on shaped types of encrypted values?)
There was a problem hiding this comment.
The tfhe-rs-bool emitter only produces EncryptedBools
I added an additional check
WoutLegiest
added
the
pull_ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.