Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poly: add ntt and intt ops #570

Merged
merged 1 commit into from Mar 29, 2024
Merged

poly: add ntt and intt ops #570

merged 1 commit into from Mar 29, 2024

Conversation

inbelic
Copy link
Contributor

@inbelic inbelic commented Mar 27, 2024

  • Intoduce ntt/intt ops that convert them to/from tensors with their ideal ring attributes encoded
  • These tensors allow for the polynomial to be in the corresponding point-value representation for more efficient polynomial multiplicaiton

Resolves #182

@inbelic
Copy link
Contributor Author

inbelic commented Mar 27, 2024

Not quite happy with the summary and description of the operations. Would like feedback on those

@inbelic inbelic marked this pull request as ready for review March 27, 2024 20:57
@j2kun j2kun requested a review from asraa March 27, 2024 21:25
asraa
asraa approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Just a couple of nits, feel free to take the suggestions as you like.

lib/Dialect/Polynomial/IR/PolynomialOps.cpp Outdated Show resolved Hide resolved
tests/polynomial/ops.mlir Show resolved Hide resolved
include/Dialect/Polynomial/IR/PolynomialOps.td Show resolved Hide resolved
include/Dialect/Polynomial/IR/PolynomialOps.td Outdated Show resolved Hide resolved
include/Dialect/Polynomial/IR/PolynomialOps.td Outdated Show resolved Hide resolved
include/Dialect/Polynomial/IR/PolynomialOps.td Outdated Show resolved Hide resolved
@inbelic
Copy link
Contributor Author

inbelic commented Mar 29, 2024

Sweet, thanks for the great review and suggestions!

@inbelic
poly: add ntt and intt ops
9df52df 
  - Intoduce ntt/intt ops that convert them to/from tensors with their
    ideal ring attributes encoded
  - These tensors allow for the polynomial to be in the corresponding
    point-value representation for more efficient polynomial
    multiplicaiton

Resolves google#182
@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Mar 29, 2024
@copybara-service copybara-service bot merged commit fe238e9 into google:main Mar 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j2kun j2kun j2kun approved these changes

@asraa asraa asraa approved these changes

Assignees
No one assigned
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[poly]: add poly.ntt/intt ops
3 participants
@inbelic @j2kun @asraa