Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Unskip TestGCPBrokerMetrics in WI mode #1452

Merged
merged 1 commit into from Jul 15, 2020

Conversation

ian-mi
Copy link
Contributor

@ian-mi ian-mi commented Jul 14, 2020

Flakiness should have been fixed by census-instrumentation/opencensus-go#1220. Fixes #1346.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ian-mi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Jul 14, 2020
@grac3gao-zz
Copy link
Contributor

/lgtm

Thanks for fixing it! @ian-mi

@ian-mi
Copy link
Contributor Author

ian-mi commented Jul 14, 2020

thanks! Fingers crossed there are no more issues.

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-integration-tests 2020-07-14 22:36:30.859 +0000 UTC
2020-07-14 23:13:30.391 +0000 UTC
2/3
pull-google-knative-gcp-wi-tests 2020-07-14 22:41:00.495 +0000 UTC
2020-07-14 23:19:30.446 +0000 UTC
2/3

Automatically retrying due to test flakiness...
/test pull-google-knative-gcp-wi-tests

@knative-prow-robot knative-prow-robot merged commit e12943b into google:master Jul 15, 2020
@ian-mi ian-mi deleted the unskip-wi-metrics branch July 15, 2020 06:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky: Flaky TestGCPBrokerMetrics in WI e2e test
5 participants