Skip to content

Commit

Permalink
Use JDK8 by default in test and releases
Browse files Browse the repository at this point in the history
Gradle sets required org.gradle.jvm.version by JAVA_HOME. Therefore,
building KSP with JDK11 produces binaries that depend on Java 11 at
minimum.
  • Loading branch information
ting-yuan committed Feb 9, 2021
1 parent db48220 commit 9f87fad
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 20 deletions.
21 changes: 11 additions & 10 deletions .github/workflows/main.yml
Expand Up @@ -17,16 +17,6 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Setup Java 8
uses: actions/setup-java@v1.4.3
with:
java-version: '8'
java-package: jdk
architecture: x64
- name: set JDK 6,7,8 environment variables for kotlin compiler
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
run: echo ::set-env name=JDK_16::$(echo $JAVA_HOME) && echo ::set-env name=JDK_17::$(echo $JAVA_HOME) && echo ::set-env name=JDK_18::$(echo $JAVA_HOME)
- name: Setup Java 9
uses: actions/setup-java@v1.4.3
with:
Expand All @@ -43,6 +33,17 @@ jobs:
java-version: '11'
java-package: jdk
architecture: x64
- name: Setup Java 8
uses: actions/setup-java@v1.4.3
with:
java-version: '8'
java-package: jdk
architecture: x64
- name: set JDK 6,7,8 environment variables for kotlin compiler
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
run: echo ::set-env name=JDK_16::$(echo $JAVA_HOME) && echo ::set-env name=JDK_17::$(echo $JAVA_HOME) && echo ::set-env name=JDK_18::$(echo $JAVA_HOME)

# Checkout
- uses: actions/checkout@v2

Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/release.yml
Expand Up @@ -15,16 +15,6 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Setup Java 8
uses: actions/setup-java@v1.4.3
with:
java-version: '8'
java-package: jdk
architecture: x64
- name: set JDK 6,7,8 environment variables for kotlin compiler
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
run: echo ::set-env name=JDK_16::$(echo $JAVA_HOME) && echo ::set-env name=JDK_17::$(echo $JAVA_HOME) && echo ::set-env name=JDK_18::$(echo $JAVA_HOME)
- name: Setup Java 9
uses: actions/setup-java@v1.4.3
with:
Expand All @@ -41,6 +31,16 @@ jobs:
java-version: '11'
java-package: jdk
architecture: x64
- name: Setup Java 8
uses: actions/setup-java@v1.4.3
with:
java-version: '8'
java-package: jdk
architecture: x64
- name: set JDK 6,7,8 environment variables for kotlin compiler
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
run: echo ::set-env name=JDK_16::$(echo $JAVA_HOME) && echo ::set-env name=JDK_17::$(echo $JAVA_HOME) && echo ::set-env name=JDK_18::$(echo $JAVA_HOME)

# Checkout
- uses: actions/checkout@v2
Expand Down

0 comments on commit 9f87fad

Please sign in to comment.