Scan Kotlin constants for JavaPsiFacade #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ting-yuan
force-pushed
the
issue-997
branch
2 times, most recently
from
70f6be5
to
cd3db69
Compare
neetopia
reviewed
Oct 6, 2022
| }, | ||
| Unit | ||
| ) | ||
| } catch (_: Exception) { |
There was a problem hiding this comment.
what's the case for exception here and why it is simply ignored for the general Exception rather than more specific exception types?
There was a problem hiding this comment.
It's similar to the initialization blocks protected by handleException in the above. Exceptions can arise from, e.g., broken inputs. This is the best effort to make constants in Kotlin available to JavaPsiFacade and try not to error out if possible. It's up to the processors to decide whether to error out or not.
integration-tests/src/test/kotlin/com/google/devtools/ksp/test/Playground3IT.kt
Outdated
Show resolved
Hide resolved
|
The issue only comes from clean files. The check would be redundant because only clean files are (needed to be) visited. |
so that constants in light classes can be resolved by JavaPsiFacade.
neetopia
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that constants in light classes can be resolved by JavaPsiFacade.
Fixes #997.