fix modifier calculation for synthetic members #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test result is only modified for KSP2 for the reason that KSP2 treats Java annotation values as properties while KSP1 treats it as functions, therefore the test processor does not look into Java annotation values in KSP1.
One change to shared logic:
isOpen()should always check forFINALmodifier first, this hasn't been an issue for KSP1 since certain synthetic members of data class (namelycomponentX) is not generated in KSP1, but ran into issue with KSP2 where theOVERRIDEmodifier present incomponentXtake over theisOpencheck.