Skip to content
This repository has been archived by the owner on Jun 30, 2023. It is now read-only.

feat/backup #64

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat/backup #64

wants to merge 13 commits into from

Conversation

karchx
Copy link
Contributor

@karchx karchx commented Jun 28, 2022

JARs backup at the time of running the inspection on the jar files, either a scan or with the --rewrite command, for example

log4scanner -b -w ./jar/testdata

the copy of the JARs is saved in

backup/*.jar
  • '*' any filename

This may solve the issues:

Any improvement will be a pleasure to carry it out

jar/backup.go Outdated Show resolved Hide resolved
jar/backup.go Outdated Show resolved Hide resolved
jar/backup.go Outdated Show resolved Hide resolved
jar/backup.go Outdated Show resolved Hide resolved
jar/backup.go Outdated Show resolved Hide resolved
jar/backup_test.go Outdated Show resolved Hide resolved
jar/walker.go Outdated Show resolved Hide resolved
jar/walker.go Outdated Show resolved Hide resolved
@karchx
Copy link
Contributor Author

karchx commented Jun 29, 2022

@ericchiang
Done, Any improvement I would be very grateful if you mention it and so I work on it, but I think it's pretty good.

jar/backup_test.go Outdated Show resolved Hide resolved
jar/backup.go Outdated Show resolved Hide resolved
jar/backup.go Outdated Show resolved Hide resolved
jar/walker.go Outdated Show resolved Hide resolved
@ericchiang
Copy link
Member

Thanks! mostly just a comment about creating a new directory vs not

@karchx
Copy link
Contributor Author

karchx commented Jun 30, 2022

Done

Copy link
Member

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! two nits

jar/backup.go Outdated Show resolved Hide resolved
jar/backup.go Outdated Show resolved Hide resolved
@ericchiang
Copy link
Member

also, can you please squash your commits?

@karchx
Copy link
Contributor Author

karchx commented Jun 30, 2022

@ericchiang I was squashing commits and the PR seemed to be closed

@karchx karchx reopened this Jun 30, 2022
@ericchiang
Copy link
Member

It looks like you've got some conflicts? If you need to open a new PR feel free, or I can pull in the changes myself.

@karchx
Copy link
Contributor Author

karchx commented Jun 30, 2022

If it's not too much of a problem, I'll leave it to you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants