Support customer logger #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When martian is used as package, it needs to work along with the host's logging infrastructure. By default, it retains current logging, provides an option to change it if needed.
|
FYI, I haven't wrapped the SetLogger in a lock, anticipating it to be used once, from init() or so. But if you think, we should support dynamically changing it, I could wrap it in the same lock. |
|
@bramhaghosh wondering if you had a chance to look this? thanks. |
bramhaghosh
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When martian is used as package, it needs to work along with the host's
logging infrastructure. This change adds support for custom logging.
By default, it retains current logging, provides an option to change the logger if needed.