Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: temporarily workaround node 18 source-map issue #211

Closed
wants to merge 1 commit into from

Conversation

amchiclet
Copy link
Contributor

@amchiclet amchiclet commented Apr 30, 2022

This PR uses a beta version of source-map which works around its incompatibility with node 18. The most recent official version doesn't work with node 18 yet.

An alternative solution is to workaround it when importing source-map, like this PR.

I've chosen the simpler path for now to just use the beta version and will revisit this issue probably a couple of weeks later to see if there's any update from source-map or not.

Our kokoro tests run into a different issue that I'll address in a separate PR, but the github workflow tests should pass now.

@amchiclet
Copy link
Contributor Author

Subsumed by #213

@amchiclet amchiclet closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant