Add custom FBLPromises modulemap to cocoapods #131

mlfairy · 2019-10-01T02:46:30Z

This is to address the issue described in this ticket: #130

googlebot · 2019-10-01T02:46:33Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

mlfairy · 2019-10-01T02:47:36Z

@googlebot I signed it!

googlebot · 2019-10-01T02:47:39Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

vijaysharm · 2019-10-01T02:48:51Z

@googlebot I consent

googlebot · 2019-10-01T02:48:54Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

ghost · 2019-10-03T00:44:40Z

PromisesObjC.podspec

  s.xcconfig = {
    'HEADER_SEARCH_PATHS' => "\"${PODS_TARGET_SRCROOT}/Sources/#{s.module_name}/include\""
  }


Will this still work if we remove s.xcconfig and use s.pod_target_xcconfig instead?

ghost · 2019-10-03T00:44:53Z

PromisesObjC.podspec

@@ -23,9 +23,14 @@ Pod::Spec.new do |s|
  s.public_header_files = "Sources/#{s.module_name}/include/**/*.h"
  s.private_header_files = "Sources/#{s.module_name}/include/FBLPromisePrivate.h"
  s.source_files = "Sources/#{s.module_name}/**/*.{h,m}"
+  s.module_map = "Sources/#{s.module_name}/include/framework.modulemap"
+  s.preserve_path = "Sources/#{s.module_name}/include/framework.modulemap"


Is this needed?

Hi @temrich! do you specifically mean preserve_path or do you mean both preserve_path and module_map?

Ill try playing with a combination of both.

preserve_path, but also curious why module_map is needed as well. Also, which version of CocoaPods are you using?

ghost · 2019-10-03T00:45:42Z

Thank you for the PR! Left a couple of comments. Are you able to verify that these changes work for iOS as well?

mlfairy · 2019-10-03T00:48:18Z

Thanks @temrich, Ill give each one of your comments a go, and get back to you.

mlfairy · 2019-10-03T01:54:26Z

@temrich I updated the PR with only the lines necessary for the module map to be included in the pod. Let me know if there's anything else I can do to help!

ghost · 2019-10-03T02:51:47Z

Thank you! Were you able to verify that this change works for both macOS and iOS? Also, which version of CocoaPods are you using?

mlfairy · 2019-10-03T02:53:08Z

@temrich I tried it on osx, and ios (and tvos just for good measure). Im currently on cocoapods 1.7.5

ghost · 2019-10-03T03:36:42Z

Thank you for verifying! Any idea why specifying the module_map is not required for iOS but is for OSX?

mlfairy · 2019-10-03T12:07:19Z

@temrich I can't explain why this only affects osx. The issue peaked my understanding of cocoapods and Xcode builds. This isn't a problem with Carthage or SPM, but im guessing that's because they both are using the project or targets to actually build the framework (which defines and uses the custom modulemap). In the case of cocoapods. it seems to be creating the project from the source files (including creating its own modulemap), without taking anything from the project/target itself.

Why this seems to affect osx and not any other platform is beyond my understanding. I tried to get to the root cause, but didnt come up with anything

ghost · 2019-10-03T19:01:25Z

I tried looking into this a bit more. It's interesting, I am seeing test errors when I run:
pod spec lint PromisesObjC.podspec --no-clean --platforms=ios

but not when I run:

pod spec lint PromisesObjC.podspec --no-clean --platforms=osx

Do you see the same?

mlfairy · 2019-10-03T19:10:43Z

Hi @temrich

I just did a clean checkout and im not seeing error?

$ pod spec lint PromisesObjC.podspec --no-clean --platforms=ios

 -> PromisesObjC (1.2.8)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description
    - NOTE  | [iOS] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')

Pods workspace available at `/var/folders/xp/jw8rssf12bz6mxy7fskgt_380000gn/T/CocoaPods-Lint-20191003-56438-1iemkmu-PromisesObjC/App.xcworkspace` for inspection.

Analyzed 1 podspec.

PromisesObjC.podspec passed validation.

$ pod spec lint PromisesObjC.podspec --no-clean --platforms=macos

 -> PromisesObjC (1.2.8)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description

Pods workspace available at `/var/folders/xp/jw8rssf12bz6mxy7fskgt_380000gn/T/CocoaPods-Lint-20191003-60715-swi1d4-PromisesObjC/App.xcworkspace` for inspection.

Analyzed 1 podspec.

PromisesObjC.podspec passed validation.

Again, I'm on cocoapods 1.7.5. If there's a version you'd like me to test with, im more than happy to do so.

mlfairy · 2019-10-03T19:11:53Z

Also, did you mean to run pod spec lint or pod lib lint? Are you checking the remote podspec or the local one?

ghost · 2019-10-03T19:26:01Z

I am using 1.7.5 as well. pod spec lint, was checking my local version without your changes.

@paulb777, anything else we should try to verify to determine whether this is a CocoaPods bug or not?

paulb777 · 2019-10-03T20:00:21Z

The default Xcode version might make a difference

mlfairy · 2019-10-03T20:38:13Z

Hi @paulb777 I tried it with Xcode 11 and Xcode 10.3, both seem to give me the error without patch, and pass with the patch.

eytanbiala · 2020-03-11T16:26:23Z

Hey, I think this also causes missing modulemaps when using Xcode's preprocessing of a file, error:

Module map file '~/Library/Developer/Xcode/DerivedData/app-aqiyiglyrsbmvzhjitgjbclucaxz/Build/Products/AppStore-iphonesimulator/PromisesSwift/Promises.modulemap' not found

Is there any reason not to merge this PR?

sgehrman · 2022-07-06T08:51:30Z

dyld[50618]: Library not loaded: @rpath/FBLPromises.framework/Versions/A/FBLPromises
Referenced from: /Users/steve/Library/Developer/Xcode/DerivedData/Runner-dxohvkdpondjoxcgfbjhylmeoezo/Build/Products/Debug/Dashboard.app/Contents/MacOS/Dashboard
Reason: tried: '/Users/steve/Library/Developer/Xcode/DerivedData/Runner-dxohvkdpondjoxcgfbjhylmeoezo/Build/Products/Debug/FBLPromises.framework/Versions/A/FBLPromises' (no such file), '/usr/lib/swift/FBLPromises.framework/Versions/A/FBLPromises' (no such file), '/Users/steve/Library/Developer/Xcode/DerivedData/Runner-dxohvkdpondjoxcgfbjhylmeoezo/Build/Products/Debug/Dashboard.app/Contents/MacOS/../Frameworks/FBLPromises.framework/Versions/A/FBLPromises' (code signature in <4EFC1C03-34BA-302C-8153-DF1B0507C339> '/Users/steve/Library/Developer/Xcode/DerivedData/Runner-dxohvkdpondjoxcgfbjhylmeoezo/Build/Products/Debug/Dashboard.app/Contents/Frameworks/FBLPromises.framework/Versions/A/FBLPromises' not valid for use in process: mapped file has no Team ID and is not a platform binary (signed with custom identity or adhoc?)), '/Users/steve/Library/Developer/Xcode/DerivedData/Runner-dxohvkdpondjoxcgfbjhylmeoezo/Build/Products/Debug/Dashboard.app/Contents/MacOS/Frameworks/FBLPromises.framework/Versions/A/FBLPromises' (no such file), '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx/FBLPromises.framework/Versions/A/FBLPromises' (no such file), '/Users/steve/Library/Developer/Xcode/DerivedData/Runner-dxohvkdpondjoxcgfbjhylmeoezo/Build/Products/Debug/Dashboard.app/Contents/MacOS/../Frameworks/FBLPromises.framework/Versions/A/FBLPromises' (code signature in <4EFC1C03-34BA-302C-8153-DF1B0507C339> '/Users/steve/Library/Developer/Xcode/DerivedData/Runner-dxohvkdpondjoxcgfbjhylmeoezo/Build/Products/Debug/Dashboard.app/Contents/Frameworks/FBLPromises.framework/Versions/A/FBLPromises' not valid for use in process: mapped file has no Team ID and is not a platform binary (signed with custom identity or adhoc?)), '/usr/lib/swift/FBLPromises.framework/Versions/A/FBLPromises' (no such file), '/Users/steve/Library/Developer/Xcode/DerivedData/Runner-dxohvkdpondjoxcgfbjhylmeoezo/Build/Products/Debug/Dashboard.app/Contents/MacOS/../Frameworks/FBLPromises.framework/Versions/A/FBLPromises' (code signature in <4EFC1C03-34BA-302C-8153-DF1B0507C339> '/Users/steve/Library/Developer/Xcode/DerivedData/Runner-dxohvkdpondjoxcgfbjhylmeoezo/Build/Products/Debug/Dashboard.app/Contents/Frameworks/FBLPromises.framework/Versions/A/FBLPromises' not valid for use in process: mapped file has no Team ID and is not a platform binary (signed with custom identity or adhoc?)), '/Users/steve/Library/Developer/Xcode/DerivedData/Runner-dxohvkdpondjoxcgfbjhylmeoezo/Build/Products/Debug/Dashboard.app/Contents/MacOS/Frameworks/FBLPromises.framework/Versions/A/FBLPromises' (no such file), '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx/FBLPromises.framework/Versions/A/FBLPromises' (no such file), '/Users/steve/Library/Developer/Xcode/DerivedData/Runner-dxohvkdpondjoxcgfbjhylmeoezo/Build/Products/Debug/Dashboard.app/Contents/MacOS/../Frameworks/FBLPromises.framework/Versions/A/FBLPromises' (code signature in <4EFC1C03-34BA-302C-8153-DF1B0507C339> '/Users/steve/Library/Developer/Xcode/DerivedData/Runner-dxohvkdpondjoxcgfbjhylmeoezo/Build/Products/Debug/Dashboard.app/Contents/Frameworks/FBLPromises.framework/Versions/A/FBLPromises' not valid for use in process: mapped file has no Team ID and is not a platform binary (signed with custom identity or adhoc?)), '/Library/Frameworks/FBLPromises.framework/Versions/A/FBLPromises' (no such file), '/System/Library/Frameworks/FBLPromises.framework/Versions/A/FBLPromises' (no such file)

ghost reviewed Oct 3, 2019

View reviewed changes

mlfairy force-pushed the master branch from 5ffdbdb to 2399445 Compare October 3, 2019 01:44

Add path to module_map to PromisesObjC podspec

e4364c2

mlfairy force-pushed the master branch from 2399445 to e4364c2 Compare October 3, 2019 01:47

eytanbiala approved these changes Mar 11, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add custom FBLPromises modulemap to cocoapods #131

Add custom FBLPromises modulemap to cocoapods #131

mlfairy commented Oct 1, 2019

googlebot commented Oct 1, 2019

mlfairy commented Oct 1, 2019

googlebot commented Oct 1, 2019

vijaysharm commented Oct 1, 2019

googlebot commented Oct 1, 2019

ghost Oct 3, 2019

ghost Oct 3, 2019

mlfairy Oct 3, 2019

ghost Oct 3, 2019

ghost commented Oct 3, 2019

mlfairy commented Oct 3, 2019

mlfairy commented Oct 3, 2019

ghost commented Oct 3, 2019

mlfairy commented Oct 3, 2019

ghost commented Oct 3, 2019

mlfairy commented Oct 3, 2019

ghost commented Oct 3, 2019

mlfairy commented Oct 3, 2019

mlfairy commented Oct 3, 2019 •

edited

ghost commented Oct 3, 2019

paulb777 commented Oct 3, 2019

mlfairy commented Oct 3, 2019 •

edited

eytanbiala commented Mar 11, 2020

sgehrman commented Jul 6, 2022

Add custom FBLPromises modulemap to cocoapods #131

Are you sure you want to change the base?

Add custom FBLPromises modulemap to cocoapods #131

Conversation

mlfairy commented Oct 1, 2019

googlebot commented Oct 1, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

mlfairy commented Oct 1, 2019

googlebot commented Oct 1, 2019

vijaysharm commented Oct 1, 2019

googlebot commented Oct 1, 2019

ghost Oct 3, 2019

Choose a reason for hiding this comment

ghost Oct 3, 2019

Choose a reason for hiding this comment

mlfairy Oct 3, 2019

Choose a reason for hiding this comment

ghost Oct 3, 2019

Choose a reason for hiding this comment

ghost commented Oct 3, 2019

mlfairy commented Oct 3, 2019

mlfairy commented Oct 3, 2019

ghost commented Oct 3, 2019

mlfairy commented Oct 3, 2019

ghost commented Oct 3, 2019

mlfairy commented Oct 3, 2019

ghost commented Oct 3, 2019

mlfairy commented Oct 3, 2019

mlfairy commented Oct 3, 2019 • edited

ghost commented Oct 3, 2019

paulb777 commented Oct 3, 2019

mlfairy commented Oct 3, 2019 • edited

eytanbiala commented Mar 11, 2020

sgehrman commented Jul 6, 2022

mlfairy commented Oct 3, 2019 •

edited

mlfairy commented Oct 3, 2019 •

edited