Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with kotlin gradle plugin for Android #201

Merged
merged 1 commit into from
Jan 2, 2018
Merged

Integrate with kotlin gradle plugin for Android #201

merged 1 commit into from
Jan 2, 2018
+341 −233

Conversation

zpencer
Copy link
Contributor

@zpencer zpencer commented Dec 20, 2017 •
edited
Loading

GenerateProtoTask:

  • return a SourceDirectorySet, which is universally understood by both java compile and kotlin compile

I have a follow up PR to clean up the tests by introducing a test project builder utility.

@zpencer zpencer requested a review from zhangkun83 December 20, 2017 19:35
@zpencer zpencer merged commit 65b58a2 into google:master Jan 2, 2018
@zpencer zpencer deleted the kotlin-android-pr branch January 2, 2018 18:50
@zpencer zpencer mentioned this pull request Jan 6, 2018
Closed
zhangkun83 pushed a commit to zhangkun83/protobuf-gradle-plugin-1 that referenced this pull request Nov 7, 2018
@zpencer @zhangkun83
Integrate with kotlin gradle plugin for Android (google#201)
55a9d15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangkun83 zhangkun83

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zpencer @zhangkun83