fix gotcha that requires kotlin plugin be applied before protobuf #208
+31
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangkun83
reviewed
Jan 20, 2018
| project.tasks.whenTaskAdded { Task task -> | ||
| if (task.name == compileTaskName) { | ||
| task.dependsOn(genProtoTask) | ||
| task.source genProtoTask.getOutputSourceDirectorySet() |
There was a problem hiding this comment.
These two lines could be refactored into a method.
zhangkun83
approved these changes
Jan 22, 2018
zhangkun83
pushed a commit
to zhangkun83/protobuf-gradle-plugin-1
that referenced
this pull request
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned I noticed some weirdness while working on the plugin
for android. It was caused by the unit test project applying
protobuf before kotlin-android. The result is that when the
proto plugin is configured, the kotlin tasks will not be created
yet.
This PR fixes the issue and allows applying plugins in any order.