Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf upgrade to 3.14.0 #595

Closed
jwijffels opened this issue Dec 8, 2020 · 2 comments
Closed

protobuf upgrade to 3.14.0 #595

jwijffels opened this issue Dec 8, 2020 · 2 comments

Comments

@jwijffels
Copy link

Protobuf v3.14.0 was released 25 days ago: https://github.com/protocolbuffers/protobuf/releases/tag/v3.14.0
Will you be planning to update the sentencepiece package with it?
If yes, that would solve the issue reported at #432 (comment) as fixes were applied in protobuf release v3.14.0 in order to fix UBSAN compilation issues (trace here protocolbuffers/protobuf#2073).
That would allow me to upgrade the sentencepiece R package on CRAN as this UBSAN compilation issue was a blocking factor there.

thank you!
@taku910 taku910 mentioned this issue Dec 21, 2020
Closed
@taku910
Copy link
Collaborator

taku910 commented Jan 8, 2021

Done in v0.19.5

@taku910 taku910 closed this as completed Jan 8, 2021
@jwijffels
Copy link
Author

Thank you! I'll look into it.

@jwijffels jwijffels mentioned this issue Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwijffels @taku910