Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/4619 backstopjs image #5692

Merged
merged 15 commits into from Sep 2, 2022
Merged

Conversation

eugene-manuilov
Copy link
Collaborator

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Size Change: 0 B

Total Size: 1.5 MB

ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 48.3 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.1 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 5.96 kB
./dist/assets/js/31-********************.js 2.8 kB
./dist/assets/js/32-********************.js 2.28 kB
./dist/assets/js/33-********************.js 3.72 kB
./dist/assets/js/34-********************.js 51.9 kB
./dist/assets/js/35-********************.js 16.1 kB
./dist/assets/js/36-********************.js 70.9 kB
./dist/assets/js/37-********************.js 31.6 kB
./dist/assets/js/38-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 769 B
./dist/assets/js/googlesitekit-activation-********************.js 28.1 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 36.3 kB
./dist/assets/js/googlesitekit-api-********************.js 9.25 kB
./dist/assets/js/googlesitekit-base-********************.js 1.13 kB
./dist/assets/js/googlesitekit-dashboard-details-********************.js 58.9 kB
./dist/assets/js/googlesitekit-dashboard-********************.js 66.6 kB
./dist/assets/js/googlesitekit-dashboard-splash-********************.js 70.7 kB
./dist/assets/js/googlesitekit-data-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.88 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 14.9 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 8.97 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 30.3 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice-********************.js 45.1 kB
./dist/assets/js/googlesitekit-idea-hub-post-list-********************.js 26.1 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 69.2 kB
./dist/assets/js/googlesitekit-modules-analytics-********************.js 68.2 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 19 kB
./dist/assets/js/googlesitekit-modules-********************.js 19.5 kB
./dist/assets/js/googlesitekit-modules-idea-hub-********************.js 27.6 kB
./dist/assets/js/googlesitekit-modules-optimize-********************.js 19.4 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 18.5 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 38.5 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32 kB
./dist/assets/js/googlesitekit-modules-thank-with-google-********************.js 24.7 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 378 B
./dist/assets/js/googlesitekit-settings-********************.js 50.1 kB
./dist/assets/js/googlesitekit-user-input-********************.js 45 kB
./dist/assets/js/googlesitekit-vendor-********************.js 323 kB
./dist/assets/js/googlesitekit-widgets-********************.js 19.5 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 59.8 kB
./dist/assets/js/runtime-********************.js 1.34 kB

compressed-size-action

Copy link
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good and runs for me, but I have a few very minor diffs from font rendering or something that isn’t appearing in GitHub Actions 🤔

Just trying to sort that out, but after it should be good 🙂

@tofumatt
Copy link
Collaborator

tofumatt commented Sep 1, 2022

Looks like my VRT updates still work on CI, so I think this should be good.

It looks like the VRTs still run quickly despite not uploading the image to a repo, so I guess it's only built locally once? I think this is fine and we can look at uploading the image separately—this is the main thing we want (to be able to run the tests 😄 )

Copy link
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Ran successfully for me on my M1 MacBook Pro, passes on CI, and I think we're good to go!

Thanks! 🥳

@tofumatt tofumatt merged commit f03d475 into develop Sep 2, 2022
@tofumatt tofumatt deleted the enhancement/4619-backstopjs-image branch September 2, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants