Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search queries appear as links on View only dashboard #8025 is fixed successfully. #8027

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

harith-hacky03
Copy link

@harith-hacky03 harith-hacky03 commented Jan 3, 2024

Summary

Addresses issue:
Search queries appear as links on View only dashboard #8025
The issue is the Link tag always need to have the "href" even though it is undefined so it is appearing as the link.

Relevant technical choices

I conditional rendered the tag depending on the user permissions , if user has only read-only i will render the

element if they have all permissions the will be rendered .

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

google-cla bot commented Jan 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@harith-hacky03
Copy link
Author

i already signed by CLA why am i getting this Please help me .

@harith-hacky03
Copy link
Author

Can please any maintainers evaluate my PR. Thank you

@bethanylang
Copy link
Collaborator

@harith-hacky03 We will review your PR as we have time; it may take awhile as we have issues that are a higher priority. Thank you!

@harith-hacky03
Copy link
Author

@bethanylang Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants