-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement selection panel refactor #8698
Implement selection panel refactor #8698
Conversation
Build files for f6ea234 have been deleted. |
Size Change: +2.8 kB (+0.2%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nfmohit Excellent work here. Mostly looking good. I've left a few comments for you, please have a look. Cheers!
assets/js/components/KeyMetrics/MetricsSelectionPanel/MetricItem.js
Outdated
Show resolved
Hide resolved
assets/js/components/KeyMetrics/MetricsSelectionPanel/MetricItem.js
Outdated
Show resolved
Hide resolved
assets/js/components/KeyMetrics/MetricsSelectionPanel/MetricsFooter.js
Outdated
Show resolved
Hide resolved
assets/js/components/KeyMetrics/MetricsSelectionPanel/MetricsFooter.js
Outdated
Show resolved
Hide resolved
assets/js/components/KeyMetrics/MetricsSelectionPanel/MetricsFooter.js
Outdated
Show resolved
Hide resolved
assets/js/components/KeyMetrics/MetricsSelectionPanel/MetricsHeader.js
Outdated
Show resolved
Hide resolved
assets/js/components/KeyMetrics/MetricsSelectionPanel/MetricsHeader.js
Outdated
Show resolved
Hide resolved
assets/js/components/KeyMetrics/MetricsSelectionPanel/MetricsFooter.js
Outdated
Show resolved
Hide resolved
Thank you for the kind review, @kuasha420. I've responded to all your comments. This is back with you for another pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both @techanvil and @nfmohit, excellent work here and not a ounce of VRT diff (except for the new stories, of course). This is perfect. 🎉
Summary
Addresses issue:
Relevant technical choices
This PR refactors the Key Metrics selection panel to be a set of standalone components that can be re-used to create additional selection components.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist