-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include CH in CoMo regions conditionally #8704
Conversation
Build files for 90f4f55 have been deleted. |
Size Change: +148 B (+0.01%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nfmohit Thank you for the PR. The changes LGTM and the deviation from IB makes sense. I'll approve it and move it over to MR for @techanvil to have a look since he's much more familiar with CoMo. Cheers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice one @nfmohit!
I approved the PR, but then noticed a merge conflict had appeared so have merged |
Summary
Addresses issue:
Relevant technical choices
This PR adds Switzerland (CH) to the list of Consent Mode regions if it is 31 July 2024 or later, OR, if the
consentModeSwitzerland
feature flag is enabled.Deviations from IB
It was necessary to express the list of statically defined consent mode regions on the client side as the consent mode settings didn't prove to be very reliable for the regions. Suppose, in a scenario where CoMo was set up earlier and this PR gets merged now, the list of regions in consent mode settings doesn't get updated.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist