-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue / 8616 ICE Create Conversion Tracking Toggle Component #8705
Issue / 8616 ICE Create Conversion Tracking Toggle Component #8705
Conversation
…ialog components.
…eConversionTrackingDialog components.
…eature flag check.
Build files for d91e70c have been deleted. |
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely looks good, but a few small cleanups/questions before we merge 👍🏻
assets/js/components/conversion-tracking/ConversionTrackingToggle.js
Outdated
Show resolved
Hide resolved
assets/js/components/conversion-tracking/ConversionTrackingToggle.js
Outdated
Show resolved
Hide resolved
assets/js/components/conversion-tracking/ConversionTrackingToggle.js
Outdated
Show resolved
Hide resolved
assets/js/components/conversion-tracking/ConversionTrackingToggle.js
Outdated
Show resolved
Hide resolved
assets/js/components/conversion-tracking/ConversionTrackingToggle.js
Outdated
Show resolved
Hide resolved
assets/js/components/conversion-tracking/ConversionTrackingToggle.js
Outdated
Show resolved
Hide resolved
…gle.js Co-authored-by: Matthew Riley MacPherson <hi@tofumatt.com>
…gle.js Co-authored-by: Matthew Riley MacPherson <hi@tofumatt.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for getting that documentation URL added 👍🏻
Summary
Addresses issue:
<ConversionTrackingToggle />
Component #8616Relevant technical choices
<ConversionTrackingToggle />
component and associated storiesPR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist