Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/#8664 - Fix RTL styles for the Authorize Application screen custom footer #8711

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

hussain-t
Copy link
Collaborator

@hussain-t hussain-t commented May 14, 2024

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented May 14, 2024

Build files for f46fdd5 have been deleted.

Copy link

github-actions bot commented May 14, 2024

Size Change: +40 B (0%)

Total Size: 1.47 MB

Filename Size Change
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 771 B +40 B (+5.47%) 🔍
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 54.1 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.48 kB
./dist/assets/js/29-********************.js 2.8 kB
./dist/assets/js/30-********************.js 2.28 kB
./dist/assets/js/31-********************.js 3.72 kB
./dist/assets/js/32-********************.js 929 B
./dist/assets/js/33-********************.js 888 B
./dist/assets/js/34-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 778 B
./dist/assets/js/contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-activation-********************.js 23.9 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 58.2 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.5 kB
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.88 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10 kB
./dist/assets/js/googlesitekit-data-********************.js 2.18 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.14 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 19.9 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.5 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 72.3 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-main-dashboard-********************.js 113 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 27 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 111 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 111 kB
./dist/assets/js/googlesitekit-modules-********************.js 21.6 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.4 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.6 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 380 B
./dist/assets/js/googlesitekit-settings-********************.js 60.4 kB
./dist/assets/js/googlesitekit-splash-********************.js 72.5 kB
./dist/assets/js/googlesitekit-user-input-********************.js 47.6 kB
./dist/assets/js/googlesitekit-vendor-********************.js 317 kB
./dist/assets/js/googlesitekit-widgets-********************.js 33.7 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60 kB
./dist/assets/js/mailchimp-********************.js 632 B
./dist/assets/js/optin-monster-********************.js 669 B
./dist/assets/js/popup-maker-********************.js 634 B
./dist/assets/js/runtime-********************.js 1.3 kB
./dist/assets/js/woocommerce-********************.js 655 B
./dist/assets/js/wpforms-********************.js 634 B

compressed-size-action

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hussain-t, this change LGTM.

However - it has made me notice that we haven't translated the "Powered by Site Kit" copy.

This seems like an oversight - unless a deliberate decision was made to not translate it. Can you confirm one way or the other?

If we need to translate it, it might be worth including the fix in this PR as it should be a quick one. WDYT?

echo '<div class="googlesitekit-authorize-application__footer"><p>Powered by Site Kit</p></div>';

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one @hussain-t!

@techanvil techanvil merged commit 3ebdd9d into develop Jun 3, 2024
24 of 26 checks passed
@techanvil techanvil deleted the enhance/#8664-rtl-auth-app-custom-footer branch June 3, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants