-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/#8664 - Fix RTL styles for the Authorize Application screen custom footer #8711
Conversation
Build files for f46fdd5 have been deleted. |
Size Change: +40 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hussain-t, this change LGTM.
However - it has made me notice that we haven't translated the "Powered by Site Kit" copy.
This seems like an oversight - unless a deliberate decision was made to not translate it. Can you confirm one way or the other?
If we need to translate it, it might be worth including the fix in this PR as it should be a quick one. WDYT?
echo '<div class="googlesitekit-authorize-application__footer"><p>Powered by Site Kit</p></div>'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice one @hussain-t!
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist