Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Options.js #2069

Closed
wants to merge 1 commit into from
Closed

Conversation

danielrussellLA
Copy link

cleaned up various comments.

cleaned up various comments.
@arv
Copy link
Collaborator

arv commented Jan 27, 2016

Thanks for fixing all the comments.

To accept this you also have to sign the Google CLA and add yourself to AUTHORS. See https://github.com/google/traceur-compiler/blob/master/CONTRIBUTING.md for more details.

Assigning to @johnjbarton since only Googlers can verify that you have signed the CLA.

@danielrussellLA
Copy link
Author

Done. Thank you Erik!

On Tue, Jan 26, 2016 at 9:21 PM, Erik Arvidsson notifications@github.com
wrote:

Thanks for fixing all the comments.

To accept this you also have to sign the Google CLA and add yourself to
AUTHORS. See
https://github.com/google/traceur-compiler/blob/master/CONTRIBUTING.md
for more details.

Assigning to @johnjbarton https://github.com/johnjbarton since only
Googlers can verify that you have signed the CLA.


Reply to this email directly or view it on GitHub
#2069 (comment)
.

@@ -487,7 +487,7 @@ export function toDashCase(s) {
* TODO(jjb): move to src/node
* This is called by build.js to add options to the commander command line
* library.
* @param {Commander} flags The commander object.
* @param {Commander} flags the commander object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word after the type is the argument name. This change makes it read as if the word flags is a verb operating on the commander object. Perhaps flags: the commander object or flags, the commander object.

@arv arv closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants