Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for yarn berry #963

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

appsforartists
Copy link
Member

@appsforartists appsforartists commented Nov 3, 2023

Currently, wireit's test suite only covers yarn classic. This begins to include coverage for yarn berry.

This works in everything but Windows. Two months later, and we still haven't had the time/info to make it work in Windows. It's better to have some tests than no tests, so we're landing this for POSIX now, and tracking Windows testing in #1014.

@appsforartists appsforartists force-pushed the yarn-berry-tests branch 3 times, most recently from 2c43261 to 11b2e1d Compare November 3, 2023 20:33
@appsforartists
Copy link
Member Author

@rictic @aomarks if either of you wanna take a look at this

@appsforartists
Copy link
Member Author

I think this is the right direction.

We can use yarnPath to switch which version of yarn to use (which is the same that would happen in the wild). We can even encapsulate that in something like:

const getCommandForAgent(agent) => agent.startsWith('yarn') ? 'yarn' : agent

and switch the current for (const command of to for (const agent of. The only wrinkle is that we need to modify the filesystem of rig. IDK if there's an immutable way to do that, or where you'd wanna put that.

@appsforartists appsforartists force-pushed the yarn-berry-tests branch 2 times, most recently from 77e73f5 to beababc Compare January 12, 2024 00:37
@appsforartists appsforartists changed the title WIP: add tests for yarn berry add tests for yarn berry Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant