downgrade yamlfmt to go 1.18 #105
Conversation
Since I was only using one simple feature of go 1.20 and nothing unique from go 1.19, it did not really make any sense to require such a new version. Downgrading it will make it easier for pre-commit users or folks installing through `go install`. Implemented an Errors collection type to replicate the errors.Join feature from go 1.20. Fixed a small path matching issue for exclusions.
| // I wonder how this could ever happen... | ||
| log.Printf("could not create absolute path for %s: %v", path, err) |
There was a problem hiding this comment.
This literally never happens on a day-to-day basis, but an error can trigger under some improbable circumstances
Internally filepath.Abs calls the getwd syscall, which has quite a few possible errors : https://linux.die.net/man/3/getwd
Here is a small example triggering an error on purpose : https://go.dev/play/p/JoPt8x9bQJl
There was a problem hiding this comment.
Ah good to know, thank you for the information!
I think I am okay with how I'm handling this for now then; if it was able to collect that path in the first place up until this point, then failing getwd doesn't necessarily mean the program can't eventually read that file from the relative path it currently has. So logging the error and moving on will at least notify the user that if they expect that path to be excluded, something unexpected went wrong.
(I probably should have thrown a newline on that log though...)
Since I was only using one simple feature of go 1.20 and nothing unique from go 1.19, it did not really make any sense to require such a new version. Downgrading it will make it easier for pre-commit users or folks installing through
go install.Implemented an Errors collection type to replicate the errors.Join feature from go 1.20.
Fixed a small path matching issue for exclusions. Closes #97