New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide configurable `spawn` #333

Merged

antonmedv merged 2 commits into google:main from antongolub:configurable-spawn

Mar 11, 2022

Contributor

antongolub commented Mar 11, 2022 •

edited

Mocking and testing: ESM mocking is not handy, so if we'd like to override cp.spawn we have to create a new VM context with clean module cache, read files, parse them to build proper virtual refs, evaluate, etc, etc. Let's just don't.
Debug and audit. For example, we can easily wrap the default impl and capture args and stdout of all internal cmd invocations of script to some file.

Appropriate changes to README are included in PR

antongolub added 2 commits

March 11, 2022 13:55


          feat: make spawn configurable


          docs: mention $.spawn

485e902

antonmedv merged commit 73aee91 into google:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment