feat: add optional delay for retry
#335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonmedv
reviewed
Mar 13, 2022
experimental.d.ts
Outdated
| @@ -23,7 +23,7 @@ export const echo: Echo | |||
| interface Retry { | |||
| (pieces: TemplateStringsArray, ...args: any[]): Promise<ProcessOutput> | |||
| } | |||
| export const retry: (count: number) => Retry | |||
| export const retry: <C extends number = 5, D extends number = 0>(count?: C, delay?: D) => Retry | |||
There was a problem hiding this comment.
export const retry: (count: number = 5) => Retryraises TS2371: A parameter initializer is only allowed in a function or constructor implementation.
So the only way to add a default arg value to fn type declaration is via generics (afair).
antonmedv
reviewed
Mar 13, 2022
| @@ -23,7 +23,7 @@ export const echo: Echo | |||
| interface Retry { | |||
| (pieces: TemplateStringsArray, ...args: any[]): Promise<ProcessOutput> | |||
| } | |||
| export const retry: (count: number) => Retry | |||
| export const retry: (count?: number, delay?: number) => Retry | |||
There was a problem hiding this comment.
Even better. Fixes an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cmds (like
npm whoami) may hit the throttling limit, so adelaybetween call attempt might be very useful.