Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export which package as global #347

Merged
merged 4 commits into from Mar 18, 2022
Merged

feat: export which package as global #347

merged 4 commits into from Mar 18, 2022

Conversation

antongolub
Copy link
Contributor

  • Tests pass
  • Appropriate changes to README are included in PR

@antongolub antongolub mentioned this pull request Mar 15, 2022
Closed
2 tasks
@antonmedv
Copy link
Collaborator

Sync please

@antonmedv
Copy link
Collaborator

Also types

@antongolub
Copy link
Contributor Author

@antonmedv, rfr

@antonmedv
Copy link
Collaborator

Why not this way?

await $`which node`

@antongolub
Copy link
Contributor Author

antongolub commented Mar 17, 2022 •
edited

To reuse the pkg that already comes with zx. cp does not respect node_modules/.bin unlike execa.

@antonmedv
Copy link
Collaborator

It's true what which is included. Bug do we want to make it an API?

cp does not respect node_modules/.bin unlike execa.

Simple use zx from package.json:

scripts:
   run: 'zx scripts/main.mjs'

@antongolub
Copy link
Contributor Author

antongolub commented Mar 17, 2022 •
edited

which seems useful in scripts. Like glob, like echo. And if it's already included, why just not let it be used?

@antonmedv antonmedv merged commit f65b3af into google:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antongolub @antonmedv