feat: introduce experimental withTimeout helper
#355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice 👌🏻 This PR got me thinking 🤔 is there a way to create a combination of retry w/ withTimeout? It will be really nice API if it’s possible to combine different methods. |
|
I’m still suggesting to introduce internal factory |
antongolub
force-pushed
the
add-with-timeout
branch
from
f586d06
to
6073cf6
Compare
|
I'd like to refactor zx internals in separate commits. This one is complete, atomic and just brings the new api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #349