[api-common-java] Handle "-", _deleted-topic_ patterns #149
Conversation
Also fixing Travis builds.
Also fixing a warning.
* remove usage of deprecated methods in guava * Deprecated methods parellel to those deparecated in guava
* Fix PathTemplate matcher to match path with protocol and hostname
* Automatic-Module-Name added to the manifest. * Update build.gradle
…ations to v1.7.2 (#136)
fix: update mockito dependency
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
============================================
+ Coverage 63.96% 64.09% +0.13%
- Complexity 163 171 +8
============================================
Files 14 14
Lines 702 713 +11
Branches 112 118 +6
============================================
+ Hits 449 457 +8
- Misses 219 220 +1
- Partials 34 36 +2
Continue to review full report at Codecov.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it |
2048b15
to
007782e
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1 similar comment
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Closing due to a bad history merge => CLA bot, recreating in #150. |
Need to handle aip.dev/159 in addition to complex, non-/-separated resource names.