Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

[api-common-java] Handle "-", _deleted-topic_ patterns #149

Closed
wants to merge 66 commits into from

Conversation

miraleung
Copy link
Contributor

Need to handle aip.dev/159 in addition to complex, non-/-separated resource names.

garrettjonesgoogle and others added 30 commits November 2, 2017 15:50
* remove usage of deprecated methods in guava
* Deprecated methods parellel to those deparecated in guava
* Fix PathTemplate matcher to match path with protocol and hostname
* Automatic-Module-Name added to the manifest.

* Update build.gradle
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 3, 2020
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #149 into master will increase coverage by 0.13%.
The diff coverage is 84.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #149      +/-   ##
============================================
+ Coverage     63.96%   64.09%   +0.13%     
- Complexity      163      171       +8     
============================================
  Files            14       14              
  Lines           702      713      +11     
  Branches        112      118       +6     
============================================
+ Hits            449      457       +8     
- Misses          219      220       +1     
- Partials         34       36       +2     
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/api/core/AbstractApiFuture.java 83.33% <ø> (ø) 10.00 <0.00> (ø)
...n/java/com/google/api/core/AbstractApiService.java 82.14% <ø> (ø) 13.00 <0.00> (ø)
src/main/java/com/google/api/core/ApiService.java 69.23% <ø> (ø) 0.00 <0.00> (ø)
...n/java/com/google/api/core/CurrentMillisClock.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../java/com/google/api/core/ForwardingApiFuture.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/com/google/api/core/NanoClock.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...in/java/com/google/api/core/SettableApiFuture.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...google/api/pathtemplate/TemplatedResourceName.java 25.00% <ø> (ø) 6.00 <0.00> (ø)
...m/google/api/pathtemplate/ValidationException.java 16.66% <ø> (ø) 3.00 <0.00> (ø)
.../google/api/resourcenames/UntypedResourceName.java 42.85% <62.50%> (ø) 5.00 <3.00> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4caf2ca...007782e. Read the comment docs.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 3, 2020
@noahdietz noahdietz self-requested a review June 3, 2020 22:50
@noahdietz noahdietz removed their assignment Jun 3, 2020
@miraleung
Copy link
Contributor Author

@googlebot I fixed it
The CLA inclusion is marked as green in #146.

@miraleung miraleung force-pushed the miraleung/resource_names branch 2 times, most recently from 2048b15 to 007782e Compare June 4, 2020 00:07
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@miraleung
Copy link
Contributor Author

Closing due to a bad history merge => CLA bot, recreating in #150.

@miraleung miraleung closed this Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet