This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
fix: attach to v8 debugger session only when having active breakpoints #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This PR also refactos the inspector-debugapi class so that the V8 related code is moved to v8inspector class.
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: clouddebugger
Codecov Report
@@ Coverage Diff @@
## master #975 +/- ##
==========================================
+ Coverage 66.54% 66.84% +0.29%
==========================================
Files 20 20
Lines 1656 1677 +21
Branches 340 343 +3
==========================================
+ Hits 1102 1121 +19
- Misses 475 477 +2
Partials 79 79
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Jun 14, 2021
mctavish
suggested changes
Jun 14, 2021
mctavish
approved these changes
Jun 17, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 17, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [5.2.4](https://www.github.com/googleapis/cloud-debug-nodejs/compare/v5.2.3...v5.2.4) (2021-06-17) ### Bug Fixes * attach to v8 debugger session only when having active breakpoints ([#975](https://www.github.com/googleapis/cloud-debug-nodejs/issues/975)) ([031a7ad](https://www.github.com/googleapis/cloud-debug-nodejs/commit/031a7ad5c830beee318ae36a9e56b6588bc929d4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related code is moved to v8inspector class.
Fixes #811