Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency source-map to ^0.7.0 #385

Closed
wants to merge 3 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 9, 2019

This PR contains the following updates:

Package Type Update Change References
source-map dependencies minor ^0.6.1 -> ^0.7.0 source

Release Notes

mozilla/source-map

v0.7.3

Compare Source

v0.7.2

Compare Source

v0.7.1

Compare Source

  • Updated TypeScript typings. #​321

v0.7.0

Compare Source

  • SourceMapConsumer now uses WebAssembly, and is much faster! Read about
    it here:
    https://hacks.mozilla.org/2018/01/oxidizing-source-maps-with-rust-and-webassembly/

  • Breaking change: new SourceMapConsumer now returns a Promise object
    that resolves to the newly constructed SourceMapConsumer instance, rather
    than returning the new instance immediately.

  • Breaking change: when you're done using a SourceMapConsumer instance,
    you must call SourceMapConsumer.prototype.destroy on it. After calling
    destroy, you must not use the instance again.

  • Breaking change: SourceMapConsumer used to be able to handle lines,
    columns numbers and source and name indices up to 2^53 - 1 (aka
    Number.MAX_SAFE_INTEGER). It can now only handle them up to 2^32 - 1.

  • Breaking change: The source-map library now uses modern ECMAScript-isms:
    let, arrow functions, async, etc. Use Babel to compile it down to
    ECMAScript 5 if you need to support older JavaScript environments.

  • Breaking change: Drop support for Node < 8. If you want to support older
    versions of node, please use v0.6 or below.


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2019
@renovate renovate bot force-pushed the renovate/source-map-0.x branch 5 times, most recently from 8311b78 to 51d8cb8 Compare January 15, 2019 05:14
@renovate renovate bot force-pushed the renovate/source-map-0.x branch 3 times, most recently from 7fab51c to c3f3776 Compare January 23, 2019 22:13
@renovate
Copy link
Contributor Author

renovate bot commented Feb 1, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over then you can add the label rebase to this PR and Renovate will reset/recreate it.

@nolanmar511 nolanmar511 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 1, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 1, 2019
@nolanmar511
Copy link
Contributor

This version of source-map dropped support for Node 6 (cloud-debug-nodejs also uses source map, some discussion on why that module didn't switch to 0.7.0 here)

Closing this, since we want to support Node 6.

@nolanmar511 nolanmar511 closed this Feb 1, 2019
@renovate
Copy link
Contributor Author

renovate bot commented Feb 1, 2019

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (^0.7.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/source-map-0.x branch February 1, 2019 17:36
@JustinBeckwith
Copy link
Contributor

Only a few months left 😄

@aalexand
Copy link
Contributor

aalexand commented Feb 1, 2019

A few months till Node 6 EOL? Can we just drop Node 6 support then? @nolanmar511 perhaps take a look at whether we get any Node 6 traffic?

@aalexand aalexand restored the renovate/source-map-0.x branch February 1, 2019 17:59
@renovate renovate bot deleted the renovate/source-map-0.x branch February 1, 2019 18:00
@aalexand
Copy link
Contributor

aalexand commented Feb 1, 2019

Re-opening as I'd like to understand the Node.js 6 plan better. Not being able to update dependencies is not exciting.

@ofrobots
Copy link
Contributor

ofrobots commented Feb 1, 2019

This is the standard way the community operates. Around this time every year, we expect the ecosystem to start dropping support for imminently EoL versions of Node.

Here's some thoughts on the fact some modules drop support early that I have left in chat elsewhere, but copying here:

  1. Semver still works. Continue using the previous major. That code still works. Dropping support in a semver major is fine as long as the maintainer is still willing to fix important bugs, security issues on the previous major.
  2. There are only 2 months during which you care about this. Dominoes always start falling around this time.
  3. Google Cloud modules shouldn't be the set of modules that surprise everyone when they are the first to drop support for Node 6. With the dominoes starting to fall now, by the time we drop support for Node 6, users and ecosystem would be much more ready for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants