Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support restify v9-v11 #1489

Merged
merged 6 commits into from
Apr 25, 2023
Merged

feat: support restify v9-v11 #1489

merged 6 commits into from
Apr 25, 2023

Commits on Mar 7, 2023

  1. feat: support restify 9-11 

    fixes #1488
    @6utt3rfly
    6utt3rfly committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    71a0487 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. test: don't combine async/await with next() arg 

    Restify 9 added async/await support, but it requires that middleware either be `async (req, res)` or `(req, res, next)`, but not both: `async (req, res, next)`. The restify test now avoids async/await and directly uses Promises to maintain backward compatibility with earlier versions of restify
    @6utt3rfly
    6utt3rfly committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    3991785 View commit details
    Browse the repository at this point in the history

  2. test: use onRejected callback in promise for clarity 

    Co-authored-by: Punya Biswal <punya@google.com>
    @6utt3rfly @punya
    6utt3rfly and punya committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    2bb1b43 View commit details
    Browse the repository at this point in the history

  3. test: use onRejected callback in promise for clarity 

    Co-authored-by: Punya Biswal <punya@google.com>
    @6utt3rfly @punya
    6utt3rfly and punya committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    c629cb0 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. feat: restify 9-11 testing requires node > 12 

    Unit tests with restify 9-11 on node 12 reports, "Cannot find node module 'node:process'", which indicates a node compatibility issue
    @6utt3rfly
    6utt3rfly committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    bf9ec4b View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Merge branch 'main' into feat/restify11

    @6utt3rfly
    6utt3rfly committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    7c59c0e View commit details
    Browse the repository at this point in the history