Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix remaining REST transport issues #1428

Merged
merged 4 commits into from
Sep 6, 2022
Merged

Commits on Sep 1, 2022

  1. fix: Fix remaining REST transport issues

    This includes:
    1) Use message-based transcoding logic instead of dictionary-based. This fixes multiple bugs caused by dict-json-object representation mismatches fro protobuf objects. This also removes a lot of `json->dict->object->proto-plus` object conversion overhead, which was slow and very error-prone. Now all transcodding and rest-transport-specific logic is executed in terms of native protobuf (`_pb`) stubs objects. No dicts, no proto-plus, no unnecessary conversions.
    2) Fix for non-proto-plus objects in rest.py transport and in tests. This essential for APIs which  have IAM methods defined on their surface.
    3) Fix support for Any field in tests
    4) Fix creation of mock_values (do `mock_value1` instead of `mock_value_1`, since `mock_value_1` causes issues for FieldMask mocks
    vam-google committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    116b32c View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Configuration menu
    Copy the full SHA
    80cee63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a8dcd4 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Configuration menu
    Copy the full SHA
    aab62fa View commit details
    Browse the repository at this point in the history