-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): add streaming retry showcase tests #1764
Draft
daniel-sanche
wants to merge
19
commits into
main
Choose a base branch
from
streaming-retry-showcase-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the failure in googleapis/gapic-showcase#1377, we should ideally also do at least one manual check that the REST client's code handling server-streaming responses does indeed handle real server errors well. |
Marking as draft as presubmits are failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for api-core streaming retries in the gapic showcase system tests, using Streaming Sequences
There is currently one expected failing test: when testing a stream that sends partial data before raising an exception, the gprc rest client doesn't yield any of the partial data, only the exception. I'm not sure if this is caused by a bug in the showcase server, a bug in the rest client, or expected behavior (isn't "rest streaming" a contradiction?). Let me know if you have any information
Other tests will pass after streaming retries branch is merged