Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make gapic-generator-python compatible with protobuf 3.14.0 (native namespace package) #753

Merged
merged 2 commits into from Jan 28, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion BUILD.bazel
Expand Up @@ -57,8 +57,8 @@ py_binary(
python_version = "PY3",
visibility = ["//visibility:public"],
deps = [
"@com_google_protobuf//:protobuf_python",
"@com_github_grpc_grpc//src/python/grpcio/grpc:grpcio",
requirement("protobuf"),
requirement("click"),
requirement("google-api-core"),
requirement("googleapis-common-protos"),
Expand Down
6 changes: 2 additions & 4 deletions WORKSPACE
Expand Up @@ -44,11 +44,9 @@ load("@com_github_grpc_grpc//bazel:grpc_deps.bzl", "grpc_deps")

grpc_deps()

load("@upb//bazel:repository_defs.bzl", "bazel_version_repository")
load("@com_github_grpc_grpc//bazel:grpc_extra_deps.bzl", "grpc_extra_deps")

bazel_version_repository(
name = "bazel_version",
)
grpc_extra_deps()

load("@build_bazel_rules_apple//apple:repositories.bzl", "apple_rules_dependencies")

Expand Down
2 changes: 1 addition & 1 deletion repositories.bzl
Expand Up @@ -15,7 +15,7 @@ def gapic_generator_python():
requirements = "@gapic_generator_python//:requirements.txt",
)

_protobuf_version = "3.13.0"
_protobuf_version = "3.14.0"
_protobuf_version_in_link = "v%s" % _protobuf_version
_maybe(
http_archive,
Expand Down