Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use google-protobuf gem instead of third-party protobuf gem #972

Closed
dazuma opened this issue Aug 17, 2023 · 0 comments · Fixed by #999
Closed

Use google-protobuf gem instead of third-party protobuf gem #972

dazuma opened this issue Aug 17, 2023 · 0 comments · Fixed by #999
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@dazuma
Copy link
Member

dazuma commented Aug 17, 2023

The generator currently depends on the third-party gem protobuf because the official Google gem google-protobuf currently does not support custom descriptor options. There does seem to be a current effort to address this. Once that is complete, we should be able to switch to google-protobuf, which will simplify parts of the code base.
@dazuma dazuma added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 17, 2023
@dazuma dazuma mentioned this issue Dec 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Use google-protobuf instead of third-party protobuf library dazuma/gapic-generator-ruby
1 participant
@dazuma