Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use google-protobuf instead of third-party protobuf library #999

Merged
merged 2 commits into from Dec 3, 2023
Merged

feat: Use google-protobuf instead of third-party protobuf library #999

merged 2 commits into from Dec 3, 2023

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Nov 10, 2023 •
edited

  • Removed third-party protobuf gem from Gemfiles and dependencies and added google-protobuf.
  • Updated grpc-tools gem version.
  • Removed embedded common proto classes (using third-party protobuf base classes) and added common proto gems instead.
  • Updated embedded proto classes for compiler, descriptor, and snippetgen to use the google protobuf base classes.
  • Updated gem lockfiles.
  • Updated interpretation of enum fields to use symbols rather than integers.
  • Implemented a custom method for getting extended options since the current google library doesn't support this for services and methods. This required custom binary decoding of those messages.
  • Miscellaneous usage updates for the google protobuf library

Fixes #972

@dazuma dazuma force-pushed the pr/google-protobuf branch 2 times, most recently from 4b9f7ec to b1d1920 Compare November 30, 2023 23:22
@dazuma dazuma marked this pull request as ready for review November 30, 2023 23:40
@dazuma dazuma requested a review from a team as a code owner November 30, 2023 23:40
@dazuma dazuma changed the title feat: Use google-protobuf instead of third-party protobuf library [DRAFT] feat: Use google-protobuf instead of third-party protobuf library Dec 1, 2023
@dazuma dazuma merged commit a52af95 into googleapis:main Dec 3, 2023
10 checks passed
@dazuma dazuma deleted the pr/google-protobuf branch December 3, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use google-protobuf gem instead of third-party protobuf gem
1 participant
@dazuma