This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
chore: add tests for complex resource IDs #3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
miraleung
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3190 +/- ##
=========================================
Coverage 87.12% 87.12%
Complexity 6077 6077
=========================================
Files 494 494
Lines 24052 24052
Branches 2613 2613
=========================================
Hits 20956 20956
Misses 2234 2234
Partials 862 862
Continue to review full report at Codecov.
|
noahdietz
reviewed
Jun 10, 2020
|
Reverted proto formatting changes. |
noahdietz
approved these changes
Jun 11, 2020
miraleung
added a commit
that referenced
this pull request
Jun 11, 2020
It sounds like 2.7 is no longer supported, and it's currently breaking [tests](https://app.circleci.com/pipelines/github/googleapis/gapic-generator/255/workflows/b2063a3b-2ad2-4641-8952-0bc16673a242/jobs/47732/steps) for [this unrelated PR](#3190).
miraleung
added a commit
that referenced
this pull request
Jun 12, 2020
* chore: remove 2.7 from python showcase tests It sounds like 2.7 is no longer supported, and it's currently breaking [tests](https://app.circleci.com/pipelines/github/googleapis/gapic-generator/255/workflows/b2063a3b-2ad2-4641-8952-0bc16673a242/jobs/47732/steps) for [this unrelated PR](#3190). * fix: remove python 2.7 from .circleci/config.yml as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests and baseline protos to support non-slash resource name separators. That is, "-", "~", "_", ".". Tests will pass once this PR is submitted and a new release is cut.
Relevant issue here.