fix: scope the throttling metric to exclude element size calculation (#…

…1835)

This should prevent off by 1 failures in unit tests on slow vms

gax/src/main/java/com/google/api/gax/batching/BatcherImpl.java

@@ -213,6 +213,8 @@ public ApiFuture<ElementResultT> add(ElementT element) {
     // will only be done from a single calling thread.
     Preconditions.checkState(closeFuture == null, "Cannot add elements on a closed batcher");
 
+    long bytesSize = batchingDescriptor.countBytes(element);
+
     // This is not the optimal way of throttling. It does not send out partial batches, which
     // means that the Batcher might not use up all the resources allowed by FlowController.
     // The more efficient implementation should look like:
@@ -230,7 +232,7 @@ public ApiFuture<ElementResultT> add(ElementT element) {
     // defer it till we decide on if refactoring FlowController is necessary.
     Stopwatch stopwatch = Stopwatch.createStarted();
     try {
-      flowController.reserve(1, batchingDescriptor.countBytes(element));
+      flowController.reserve(1, bytesSize);
     } catch (FlowControlException e) {
       // This exception will only be thrown if the FlowController is set to ThrowException behavior
       throw FlowControlRuntimeException.fromFlowControlException(e);