Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Commit

Permalink
cleanup(batcher): removing the non-applicable TODOs comments (#834)
Browse files Browse the repository at this point in the history
* fix(batcher): fix logged messge when exception occurs post processing

This commit addresses logged message while batch post
processing.

Currently, if a batch is successful and some exception
occurs during processing then the Batcher generates an exception message
with "Batching finished with 3 batches failed" which is not an accurate
message.

After this commit, for the same scenario, the message will be
logged with "Batching finished with 3 partial failures...".

* removed unnecessary batcher message changes, Also reverted the BatcherStats method name to `recordBatchElementsCompletion()`.
  • Loading branch information
rahulKQL authored and igorbernstein2 committed Dec 27, 2019
1 parent a978719 commit bbefe87
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
Expand Up @@ -256,8 +256,6 @@ void add(ElementT element, SettableApiFuture<ElementResultT> result) {
byteCounter += descriptor.countBytes(element);
}

// TODO: Ensure that all results are resolved in case the descriptor that causes it to
// process all results or throw an exception during processing
void onBatchSuccess(ResponseT response) {
try {
descriptor.splitResponse(response, results);
Expand Down
Expand Up @@ -509,7 +509,6 @@ public void splitResponse(
+ "3 entries that failed with: 3 ArithmeticException.");
}

// TODO(rahulkql): fix this test with follow up PR related to exception in splitResponse.
@Test
public void testPartialFailureInResultProcessing() throws Exception {
final Queue<RuntimeException> queue = Queues.newArrayBlockingQueue(3);
Expand Down

0 comments on commit bbefe87

Please sign in to comment.