This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Adopt GitHub Actions in gax-java: unit tests and linkage monitor #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chingor13
approved these changes
May 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #1062 +/- ##
=========================================
Coverage 78.75% 78.75%
Complexity 1171 1171
=========================================
Files 204 204
Lines 5173 5173
Branches 413 413
=========================================
Hits 4074 4074
Misses 925 925
Partials 174 174 Continue to review full report at Codecov.
|
stephaniewang526
approved these changes
May 21, 2020
|
@stephaniewang526 @chingor13 Would you merge this? All tests passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chingor13 @stephaniewang526 Would you review this? By using GitHub Actions, we no longer need to worry about Java 7 build failure: CertPathValidatorException: signature check failed.
Worth noting that "Adopt GitHub Actions in Client Libraries" document is quite useful. Thank you.
This setup worked well for my fork in github.com/suztomo/gax-java:
suztomo#3