Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

fix: correct Compute Engine environment for DirectPath #1325

Closed
wants to merge 1 commit into from

Conversation

mohanli-ml
Copy link
Contributor

@mohanli-ml mohanli-ml commented Mar 9, 2021

As requested by #1323, we need further correct the Compute Engine environment check logic.

[Do not submit] We need to verify this PR in the produced bug before merge it.

@mohanli-ml mohanli-ml requested review from a team as code owners March 9, 2021 04:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #1325 (0fc0275) into master (27d92c6) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1325      +/-   ##
============================================
- Coverage     79.65%   79.62%   -0.03%     
+ Complexity     1248     1247       -1     
============================================
  Files           209      209              
  Lines          5461     5458       -3     
  Branches        464      464              
============================================
- Hits           4350     4346       -4     
  Misses          928      928              
- Partials        183      184       +1     
Impacted Files Coverage Δ Complexity Δ
...api/gax/grpc/InstantiatingGrpcChannelProvider.java 77.14% <40.00%> (-0.33%) 35.00 <0.00> (ø)
.../java/com/google/api/gax/batching/BatcherImpl.java 94.38% <0.00%> (-0.57%) 21.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d92c6...6b2867c. Read the comment docs.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have a test that fails without the patch. This is not optional.

@mohanli-ml mohanli-ml closed this Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants