Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

feat: pass a CallCredentials to grpc-java for DirectPath #1488

Merged
merged 8 commits into from Jan 7, 2022

Conversation

mohanli-ml
Copy link
Contributor

@mohanli-ml mohanli-ml commented Sep 22, 2021

DirectPath is going to support non-default service account. In grpc-java, we allow GoogleDefaultChannelCredentials to take a CallCredentials as input. Thus, gax-java should pass a CallCredentials to grpc-java, and no longer use ComputeEngineChannelBuilder.

Relevant grpc-java PR: grpc/grpc-java#8548.

@mohanli-ml mohanli-ml requested review from a team as code owners September 22, 2021 05:01
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2021
@chanseokoh
Copy link
Contributor

@mohanli-ml grpc/grpc-java#8548 is merged. What's the status of this PR?

@mohanli-ml
Copy link
Contributor Author

This PR is obsolete. Specifically, gax-java should use builder = GoogleDefaultChannelCredentials.newBuilder().callCredentias(MoreCallCredentials.from(credentials)).build(); instead of builder = ComputeEngineChannelBuilder.forAddress(serviceAddress, port);. I will update this PR.

Now I am waiting for the release of grpc/grpc-java#8548, and then gax-java to depend on the latest version of grpc-java. Once we have that I can update this PR and test should pass. Then this PR is ready for review.

@mohanli-ml mohanli-ml requested a review from a team as a code owner December 3, 2021 19:16
@chanseokoh
Copy link
Contributor

There's a direct conflict from the main branch. I think you should sort it out first.

@chanseokoh chanseokoh merged commit 4a7713a into googleapis:main Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants