Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

deps: update dependency com.google.api.grpc:proto-google-common-protos to v2.9.0 #1713

Merged
merged 7 commits into from Jun 16, 2022

Conversation

Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Jun 13, 2022

deps: update dependency org.threeten:threetenbp to v1.6.0
deps: update dependency org.mockito:mockito-core to v4.6.1
deps: update dependency io.grpc:grpc-bom to v1.47.0
deps: update dependency io.opencensus:opencensus-api to v0.31.1
deps: update plugin org.sonarqube to v3.4.0.2513
deps: update io.netty dependencies to v4.1.72.Final

@Neenu1995 Neenu1995 requested review from a team as code owners June 13, 2022 15:56
@Neenu1995
Copy link
Contributor Author

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
external/io_grpc_grpc_java/compiler/src/java_plugin/cpp/java_generator.cpp:25:10: fatal error: google/protobuf/compiler/java/java_names.h: No such file or directory
   25 | #include <google/protobuf/compiler/java/java_names.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
ERROR: /home/runner/work/gax-java/gax-java/gax-grpc/BUILD.bazel:57:13 Building gax-grpc/libgax_grpc_testlib.jar (36 source files) and running annotation processors (AutoValueProcessor) failed: (Exit 1): gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining [41](https://github.com/googleapis/gax-java/runs/6867425756?check_suite_focus=true#step:8:42) arguments skipped)

Bazel build failing due to change in file name from java_names.h in previous build to names.h in current build..

@suztomo
Copy link
Member

suztomo commented Jun 14, 2022

@devjgm You mentioned some error similar to this (Protobuf changed header file name and broke gRPC) in past. Is that this error above?

@devjgm
Copy link

devjgm commented Jun 14, 2022

@devjgm You mentioned some error similar to this (Protobuf changed header file name and broke gRPC) in past. Is that this error above?

That issue was fixed in grpc/grpc-java#9218, but I don't know if there's been a grpc release w/ that commit yet.

@suztomo
Copy link
Member

suztomo commented Jun 14, 2022

@devjgm Thanks! I see no release label associated with the commit (grpc/grpc-java@84edc33) yet.

@suztomo
Copy link
Member

suztomo commented Jun 14, 2022

https://github.com/grpc/grpc-java/blob/v1.47.0/compiler/src/java_plugin/cpp/java_generator.cpp#L32 (tag v1.47.0) has the same fix in the pull request.

@Neenu1995
Copy link
Contributor Author

ERROR: /home/runner/.cache/bazel/_bazel_runner/708235df2b9026c2ff59e4840c097026/external/io_grpc_grpc_java/netty/BUILD.bazel:1:13: no such package '@io_netty_netty_transport_native_unix_common//jar': The repository '@io_netty_netty_transport_native_unix_common' could not be resolved: Repository '@io_netty_netty_transport_native_unix_common' is not defined and referenced by '@io_grpc_grpc_java//netty:netty'
ERROR: Analysis of target '//gax-grpc:gax_grpc_testlib' failed; build aborted: 

Protobuf error has been resolved with 1.47.0 of grpc. But the new version is bringing in new errors.

@devjgm
Copy link

devjgm commented Jun 14, 2022

@veblush any ideas about the above error?

@Neenu1995
Copy link
Contributor Author

Looks like this PR adds @io_netty_netty_transport_native_unix_common//jar to grpc-java/netty.

@veblush
Copy link
Contributor

veblush commented Jun 15, 2022

@ejona86 (gRPC Java TL) PTAL?

@ejona86
Copy link

ejona86 commented Jun 15, 2022

I don't understand what is confusing. There's an error about a missing dependency, so you need to add the missing dependency. The Maven Artifact is io.netty:netty-transport-native-unix-common.

For most users this isn't a new dependency because netty-transport-native-epoll depends on netty-transport-native-unix-common. Also netty-shaded already included netty-transport-native-unix-common. But it seems you weren't using it already.

I don't know how you use the Netty dependencies, but I did notice they are out-of-date compared to gRPC. gRPC has been using 4.1.72.Final since grpc-java 1.44. Tcnative would be 2.0.46.Final.

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Neenu1995
Copy link
Contributor Author

Hi @ejona86,
Thanks! That worked.

@Neenu1995 Neenu1995 changed the title chore: update dependencies deps: update dependency com.google.api.grpc:proto-google-common-protos to v2.9.0 Jun 15, 2022
@Neenu1995 Neenu1995 added downstream-check:run automerge Merge the pull request once unit tests and other checks pass. labels Jun 15, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit c5eb06e into main Jun 16, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the update-depndencies-0622 branch June 16, 2022 14:16
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 16, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 17, 2022
🤖 I have created a release *beep* *boop*
---


## [2.18.2](v2.18.1...v2.18.2) (2022-06-16)


### Bug Fixes

* **deps:** update dependency com.google.api:api-common to v2.2.1 ([#1699](#1699)) ([be79d10](be79d10))
* **deps:** update dependency com.google.auth:google-auth-library-credentials to v1.7.0 ([#1700](#1700)) ([640525e](640525e))
* **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.7.0 ([#1701](#1701)) ([0f27ef7](0f27ef7))
* **deps:** update dependency com.google.http-client:google-http-client-bom to v1.42.0 ([#1702](#1702)) ([96c4fa8](96c4fa8))
* **deps:** update dependency com.google.protobuf:protobuf-bom to v3.21.1 ([#1703](#1703)) ([3e07036](3e07036))
* **deps:** update dependency io.grpc:grpc-bom to v1.47.0 ([#1704](#1704)) ([0317926](0317926))
* **deps:** update dependency io.opencensus:opencensus-api to v0.31.1 ([#1697](#1697)) ([f9f9e1e](f9f9e1e))
* **deps:** update dependency org.graalvm.sdk:graal-sdk to v22.1.0.1 ([#1698](#1698)) ([59fbff9](59fbff9))


### Dependencies

* update dependency com.google.api.grpc:proto-google-common-protos to v2.9.0 ([#1713](#1713)) ([c5eb06e](c5eb06e))
* update dependency io.grpc:grpc-bom to v1.47.0 ([c5eb06e](c5eb06e))
* update dependency io.opencensus:opencensus-api to v0.31.1 ([c5eb06e](c5eb06e))
* update dependency org.mockito:mockito-core to v4.6.1 ([c5eb06e](c5eb06e))
* update dependency org.threeten:threetenbp to v1.6.0 ([c5eb06e](c5eb06e))
* update io.netty dependencies to v4.1.72.Final ([c5eb06e](c5eb06e))
* update plugin org.sonarqube to v3.4.0.2513 ([c5eb06e](c5eb06e))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit to googleapis/sdk-platform-java that referenced this pull request Dec 16, 2022
🤖 I have created a release *beep* *boop*
---


## [2.18.2](googleapis/gax-java@v2.18.1...v2.18.2) (2022-06-16)


### Bug Fixes

* **deps:** update dependency com.google.api:api-common to v2.2.1 ([#1699](googleapis/gax-java#1699)) ([4916e82](googleapis/gax-java@4916e82))
* **deps:** update dependency com.google.auth:google-auth-library-credentials to v1.7.0 ([#1700](googleapis/gax-java#1700)) ([4d55652](googleapis/gax-java@4d55652))
* **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.7.0 ([#1701](googleapis/gax-java#1701)) ([4e83167](googleapis/gax-java@4e83167))
* **deps:** update dependency com.google.http-client:google-http-client-bom to v1.42.0 ([#1702](googleapis/gax-java#1702)) ([84acaa1](googleapis/gax-java@84acaa1))
* **deps:** update dependency com.google.protobuf:protobuf-bom to v3.21.1 ([#1703](googleapis/gax-java#1703)) ([b41d2fd](googleapis/gax-java@b41d2fd))
* **deps:** update dependency io.grpc:grpc-bom to v1.47.0 ([#1704](googleapis/gax-java#1704)) ([b6c0b8b](googleapis/gax-java@b6c0b8b))
* **deps:** update dependency io.opencensus:opencensus-api to v0.31.1 ([#1697](googleapis/gax-java#1697)) ([4759da3](googleapis/gax-java@4759da3))
* **deps:** update dependency org.graalvm.sdk:graal-sdk to v22.1.0.1 ([#1698](googleapis/gax-java#1698)) ([ac250c4](googleapis/gax-java@ac250c4))


### Dependencies

* update dependency com.google.api.grpc:proto-google-common-protos to v2.9.0 ([#1713](googleapis/gax-java#1713)) ([4c0546d](googleapis/gax-java@4c0546d))
* update dependency io.grpc:grpc-bom to v1.47.0 ([4c0546d](googleapis/gax-java@4c0546d))
* update dependency io.opencensus:opencensus-api to v0.31.1 ([4c0546d](googleapis/gax-java@4c0546d))
* update dependency org.mockito:mockito-core to v4.6.1 ([4c0546d](googleapis/gax-java@4c0546d))
* update dependency org.threeten:threetenbp to v1.6.0 ([4c0546d](googleapis/gax-java@4c0546d))
* update io.netty dependencies to v4.1.72.Final ([4c0546d](googleapis/gax-java@4c0546d))
* update plugin org.sonarqube to v3.4.0.2513 ([4c0546d](googleapis/gax-java@4c0546d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants