Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

DONT MERGE: Expose the ability to disable encryption. #458

Closed

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Jan 11, 2018

This is necessary to allow client developers to test against emulators.
Unfortunately this flag is marked as @Experimental in grpc. @garrettjonesgoogle, can you check with grpc folks if the experimental flag can be lifted?

@codecov-io
Copy link

codecov-io commented Jan 11, 2018

Codecov Report

Merging #458 into master will decrease coverage by 0.09%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #458     +/-   ##
===========================================
- Coverage     71.01%   70.92%   -0.1%     
  Complexity      743      743             
===========================================
  Files           156      156             
  Lines          3340     3346      +6     
  Branches        240      241      +1     
===========================================
+ Hits           2372     2373      +1     
- Misses          875      880      +5     
  Partials         93       93
Impacted Files Coverage Δ Complexity Δ
...api/gax/grpc/InstantiatingGrpcChannelProvider.java 39.02% <16.66%> (-1.15%) 8 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ddedab...f66df01. Read the comment docs.

@garrettjonesgoogle
Copy link
Member

I will make a request offline. Their tracking issue for removing this instance of @ExperimentalApi is grpc/grpc-java#1772 .

This is necessary to allow client developers to test against emulators.
@igorbernstein2
Copy link
Contributor Author

It seems like this feature will be GA in grpc 1.12

@sduskis
Copy link
Contributor

sduskis commented Jan 16, 2019

@igorbernstein2, this is an old PR. Can we close it?

@igorbernstein2
Copy link
Contributor Author

Yes, I worked around it using a fixed channel provider

@igorbernstein2 igorbernstein2 deleted the use-plaintext branch November 22, 2021 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants