Remove @BetaApi annotations for streaming and LRO #704

andreamlin · 2019-04-09T18:53:38Z

As part of #702

andreamlin · 2019-04-09T18:55:13Z

PTAL

codecov · 2019-04-09T19:01:40Z

Codecov Report

Merging #704 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #704   +/-   ##
=========================================
  Coverage     75.46%   75.46%           
  Complexity     1037     1037           
=========================================
  Files           196      196           
  Lines          4675     4675           
  Branches        363      363           
=========================================
  Hits           3528     3528           
  Misses          986      986           
  Partials        161      161

Impacted Files	Coverage Δ	Complexity Δ
...om/google/api/gax/rpc/ServerStreamingCallable.java	`75% <ø> (ø)`	`7 <0> (ø)`	⬇️
...oogle/api/gax/longrunning/OperationFutureImpl.java	`76.19% <ø> (ø)`	`12 <0> (ø)`	⬇️
...gle/api/gax/rpc/StateCheckingResponseObserver.java	`75% <ø> (ø)`	`5 <0> (ø)`	⬇️
...i/gax/longrunning/OperationTimedPollAlgorithm.java	`85.71% <ø> (ø)`	`4 <0> (ø)`	⬇️
...main/java/com/google/api/gax/rpc/ServerStream.java	`81.81% <ø> (ø)`	`5 <0> (ø)`	⬇️
...i/gax/retrying/SimpleStreamResumptionStrategy.java	`14.28% <ø> (ø)`	`1 <0> (ø)`	⬇️
...ax/longrunning/OperationResponsePollAlgorithm.java	`66.66% <ø> (ø)`	`5 <0> (ø)`	⬇️
...om/google/api/gax/rpc/ClientStreamingCallable.java	`100% <ø> (ø)`	`3 <0> (ø)`	⬇️
...c/main/java/com/google/api/gax/rpc/BidiStream.java	`70% <ø> (ø)`	`4 <0> (ø)`	⬇️
...java/com/google/api/gax/rpc/OperationCallable.java	`100% <ø> (ø)`	`7 <0> (ø)`	⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50bcd29...55afa42. Read the comment docs.

codecov · 2019-04-09T19:01:40Z

Codecov Report

Merging #704 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #704   +/-   ##
=========================================
  Coverage     75.46%   75.46%           
  Complexity     1037     1037           
=========================================
  Files           196      196           
  Lines          4675     4675           
  Branches        363      363           
=========================================
  Hits           3528     3528           
  Misses          986      986           
  Partials        161      161

Impacted Files	Coverage Δ	Complexity Δ
...om/google/api/gax/rpc/ServerStreamingCallable.java	`75% <ø> (ø)`	`7 <0> (ø)`	⬇️
...oogle/api/gax/longrunning/OperationFutureImpl.java	`76.19% <ø> (ø)`	`12 <0> (ø)`	⬇️
...gle/api/gax/rpc/StateCheckingResponseObserver.java	`75% <ø> (ø)`	`5 <0> (ø)`	⬇️
...i/gax/longrunning/OperationTimedPollAlgorithm.java	`85.71% <ø> (ø)`	`4 <0> (ø)`	⬇️
...main/java/com/google/api/gax/rpc/ServerStream.java	`81.81% <ø> (ø)`	`5 <0> (ø)`	⬇️
...i/gax/retrying/SimpleStreamResumptionStrategy.java	`14.28% <ø> (ø)`	`1 <0> (ø)`	⬇️
...ax/longrunning/OperationResponsePollAlgorithm.java	`66.66% <ø> (ø)`	`5 <0> (ø)`	⬇️
...om/google/api/gax/rpc/ClientStreamingCallable.java	`100% <ø> (ø)`	`3 <0> (ø)`	⬇️
...c/main/java/com/google/api/gax/rpc/BidiStream.java	`70% <ø> (ø)`	`4 <0> (ø)`	⬇️
...java/com/google/api/gax/rpc/OperationCallable.java	`100% <ø> (ø)`	`7 <0> (ø)`	⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50bcd29...55afa42. Read the comment docs.

vam-google

In General LGTM, but @igorbernstein2 should know better about streaming portion. I'm also afraid that some of the replaced @BetaApi annotations instead of being removed should be replaced with either @InternalApi or @InternalExtensionOnly.

vam-google · 2019-04-10T17:43:48Z

gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcCallableFactory.java

@@ -65,7 +65,6 @@
 import javax.annotation.Nonnull;

 /** Class with utility methods to create grpc-based direct callables. */
-@BetaApi("The surface for use by generated code is not stable yet and may change in the future.")


Why is this removed?

andreamlin · 2019-04-12T17:39:41Z

note: stubs and grpccallablefactory should be unmarked BetaApi

sduskis · 2019-05-30T19:29:55Z

@andreamlin, what's the status of this PR? Is it ready to go from your perspective?

igorbernstein2 · 2019-05-30T20:35:34Z

I asked her to wait on merging it. It removes BetaApi labels from surfaces that I would like to change:

I would like to hide the RpcFactories
I would like to introduce a new GrpcDirectStub that simply wraps the grpc callables without adding anything new
I would like to introduce the concept of an operation timeout to call context and maybe settings.

I havent had a chance to work on these yet. Is there any rush to strip these labels?

sduskis · 2019-05-30T22:12:15Z

It would be great if this PR could move forward, one way or another, since this PR is almost 2 months old. is there anything in this PR that is mergable? If not, I think that we ought to close this.

andreamlin · 2019-05-31T17:25:12Z

I can close this and turn it into an issue. @igorbernstein2 are there github issues associated with your FRs that I can link to?

elharo · 2019-11-27T13:38:39Z

This seems to have been stuck for months. Should we close it?

elharo

Can we finish this one up?

igorbernstein2 · 2020-02-27T23:36:41Z

I don't think this needs to be blocked anymore. I think I can get what I need by simply using this: #891

elharo · 2021-01-12T11:35:07Z

I'm closing for now since it appears to be out of date. reopen if you wish to continue work. The associated issue is still open.

changes;need to be pared down

69745aa

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2019

googlejavaformat

55afa42

andreamlin requested review from vam-google and igorbernstein2 April 9, 2019 18:54

vam-google reviewed Apr 10, 2019

View reviewed changes

yoshi-automation added the 🚨 This issue needs some love. label Apr 16, 2019

sduskis added needs work This is a pull request that needs a little love. and removed 🚨 This issue needs some love. labels May 28, 2019

elharo reviewed Dec 19, 2019

View reviewed changes

elharo closed this Jan 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove @BetaApi annotations for streaming and LRO #704

Remove @BetaApi annotations for streaming and LRO #704

andreamlin commented Apr 9, 2019 •

edited

andreamlin commented Apr 9, 2019

codecov bot commented Apr 9, 2019

codecov bot commented Apr 9, 2019 •

edited

vam-google left a comment

vam-google Apr 10, 2019

andreamlin commented Apr 12, 2019

sduskis commented May 30, 2019

igorbernstein2 commented May 30, 2019

sduskis commented May 30, 2019

andreamlin commented May 31, 2019

elharo commented Nov 27, 2019

elharo left a comment

igorbernstein2 commented Feb 27, 2020

elharo commented Jan 12, 2021

Remove @BetaApi annotations for streaming and LRO #704

Remove @BetaApi annotations for streaming and LRO #704

Conversation

andreamlin commented Apr 9, 2019 • edited

andreamlin commented Apr 9, 2019

codecov bot commented Apr 9, 2019

Codecov Report

codecov bot commented Apr 9, 2019 • edited

Codecov Report

vam-google left a comment

Choose a reason for hiding this comment

vam-google Apr 10, 2019

Choose a reason for hiding this comment

andreamlin commented Apr 12, 2019

sduskis commented May 30, 2019

igorbernstein2 commented May 30, 2019

sduskis commented May 30, 2019

andreamlin commented May 31, 2019

elharo commented Nov 27, 2019

elharo left a comment

Choose a reason for hiding this comment

igorbernstein2 commented Feb 27, 2020

elharo commented Jan 12, 2021

andreamlin commented Apr 9, 2019 •

edited

codecov bot commented Apr 9, 2019 •

edited